netdev - Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b99bb3-9076-ba0f-5b8b-efe8529e93fa@gmail.com>
Date:   Thu, 6 Sep 2018 01:30:19 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Vlad Buslov <vladbu@...lanox.com>, netdev@...r.kernel.org
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        davem@...emloft.net, stephen@...workplumber.org,
        ktkhai@...tuozzo.com, paulmck@...ux.vnet.ibm.com,
        nicolas.dichtel@...nd.com, leon@...nel.org,
        gregkh@...uxfoundation.org, mark.rutland@....com, fw@...len.de,
        dsahern@...il.com, lucien.xin@...il.com,
        jakub.kicinski@...ronome.com, christian.brauner@...ntu.com,
        jbenc@...hat.com
Subject: Re: [PATCH net-next 03/13] net: sched: extend Qdisc with rcu



On 09/06/2018 12:58 AM, Vlad Buslov wrote:

...

> diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
> index 18e22a5a6550..239c73f29471 100644
> --- a/include/net/sch_generic.h
> +++ b/include/net/sch_generic.h
> @@ -90,6 +90,7 @@ struct Qdisc {
>  	struct gnet_stats_queue	__percpu *cpu_qstats;
>  	int			padded;
>  	refcount_t		refcnt;
> +	struct rcu_head		rcu;
>  
>  	/*
>  	 * For performance sake on SMP, we put highly modified fields at the end

Probably better to move this at the end of struct Qdisc,
not risking unexpected performance regressions in fast path.