netdev - Re: [PATCH net-next 09/13] net: sched: extend tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXf=WgBGb2+2bNp-w=hssmbjPX6RMvjCKv2EW53yeBsVw@mail.gmail.com>
Date:   Fri, 7 Sep 2018 12:52:00 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Leon Romanovsky <leon@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>, mark.rutland@....com,
        Florian Westphal <fw@...len.de>,
        David Ahern <dsahern@...il.com>,
        lucien xin <lucien.xin@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH net-next 09/13] net: sched: extend tcf_block with rcu

On Thu, Sep 6, 2018 at 12:59 AM Vlad Buslov <vladbu@...lanox.com> wrote:
>
> Extend tcf_block with rcu to allow safe deallocation when it is accessed
> concurrently.

This sucks, please fold this patch into where you call rcu_read_lock()
on tcf block.

This patch _alone_ is apparently not complete. This is not how
we split patches.