netdev - Re: [PATCH net-next 08/13] net: sched: rename tcf_block_get{_ext}() and tcf_block_put{

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVMU7nPgkw+N_V6ukrH5rx-37+nd+++wj47JRA33RqMUQ@mail.gmail.com>
Date:   Fri, 7 Sep 2018 13:09:08 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Leon Romanovsky <leon@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>, mark.rutland@....com,
        Florian Westphal <fw@...len.de>,
        David Ahern <dsahern@...il.com>,
        lucien xin <lucien.xin@...il.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Jiri Benc <jbenc@...hat.com>
Subject: Re: [PATCH net-next 08/13] net: sched: rename tcf_block_get{_ext}()
 and tcf_block_put{_ext}()

On Thu, Sep 6, 2018 at 12:59 AM Vlad Buslov <vladbu@...lanox.com> wrote:
>
> Functions tcf_block_get{_ext}() and tcf_block_put{_ext}() actually
> attach/detach block to specific Qdisc besides just taking/putting
> reference. Rename them according to their purpose.

Where exactly does it attach to?

Each qdisc provides a pointer to a pointer of a block, like
&cl->block. It is where the result is saved to. It takes a parameter
of Qdisc* merely for read-only purpose.

So, renaming it to *attach() is even confusing, at least not
any better. Please find other names or leave them as they are.