netdev - Re: [Patch net v2] rds: fix two RCU related problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8db3ccd-9cf3-3e55-ea55-b1935d9c46e0@oracle.com>
Date:   Mon, 10 Sep 2018 18:33:03 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Cc:     Sowmini Varadhan <sowmini.varadhan@...cle.com>,
        rds-devel@....oracle.com
Subject: Re: [Patch net v2] rds: fix two RCU related problems

On 9/10/2018 6:27 PM, Cong Wang wrote:
> When a rds sock is bound, it is inserted into the bind_hash_table
> which is protected by RCU. But when releasing rds sock, after it
> is removed from this hash table, it is freed immediately without
> respecting RCU grace period. This could cause some use-after-free
> as reported by syzbot.
> 
> Mark the rds sock with SOCK_RCU_FREE before inserting it into the
> bind_hash_table, so that it would be always freed after a RCU grace
> period.
> 
> The other problem is in rds_find_bound(), the rds sock could be
> freed in between rhashtable_lookup_fast() and rds_sock_addref(),
> so we need to extend RCU read lock protection in rds_find_bound()
> to close this race condition.
> 
> Reported-and-tested-by: syzbot+8967084bcac563795dc6@...kaller.appspotmail.com
> Reported-by: syzbot+93a5839deb355537440f@...kaller.appspotmail.com
> Cc: Sowmini Varadhan <sowmini.varadhan@...cle.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@...cle.com>
> Cc: rds-devel@....oracle.com
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
Thank you !!
Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>