netdev - Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9868264b-b337-1880-fba2-604b9d73c6c8@kernel.org>
Date:   Thu, 13 Sep 2018 10:03:06 -0500
From:   Timur Tabi <timur@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Wang Dongsheng <dongsheng.wang@...-semitech.com>
Cc:     davem@...emloft.net, yu.zheng@...-semitech.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support

On 9/13/18 7:42 AM, Andrew Lunn wrote:
> This is a pretty big patch, and is hard to review. Could you try to
> break it up into a number of smaller patches. You could for example
> first refactor emacs_phy_config(), without making any functional
> changes. Then add the sharing. Maybe do OF an ACPI in different
> patches?

Yes, please.