netdev - Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180913124229.GD11702@lunn.ch>
Date:   Thu, 13 Sep 2018 14:42:29 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Wang Dongsheng <dongsheng.wang@...-semitech.com>
Cc:     timur@...nel.org, davem@...emloft.net, yu.zheng@...-semitech.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: qcom/emac: add shared mdio bus support

On Thu, Sep 13, 2018 at 05:04:53PM +0800, Wang Dongsheng wrote:
> Share the mii_bus for others MAC device because QDF2400 emac
> include MDIO, and the motherboard has more than one PHY connected
> to an MDIO bus.
> 
> Tested: QDF2400 (ACPI), buildin/insmod/rmmod
> 
> Signed-off-by: Wang Dongsheng <dongsheng.wang@...-semitech.com>

Hi Wang

This is a pretty big patch, and is hard to review. Could you try to
break it up into a number of smaller patches. You could for example
first refactor emacs_phy_config(), without making any functional
changes. Then add the sharing. Maybe do OF an ACPI in different
patches?

Thanks
	 Andrew