netdev - Re: [PATCH 1/2] netlink: add NLA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180913.155934.742447935316828936.davem@davemloft.net>
Date:   Thu, 13 Sep 2018 15:59:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        mkubecek@...e.cz, johannes.berg@...el.com
Subject: Re: [PATCH 1/2] netlink: add NLA_REJECT policy type

From: Johannes Berg <johannes@...solutions.net>
Date: Thu, 13 Sep 2018 10:46:02 +0200

> +					NL_SET_BAD_ATTR(extack, nla);
> +					if (extack && !extack->_msg)
> +						NL_SET_ERR_MSG(extack,
> +							       "Attribute failed policy validation");

Given the lively discussion that resulted from this conditional I am
pretty sure we want to override existing messages.

If we have an existing message, and we continued to process and
parse anyways, then the existing message was informational or
a warning.

The message should be overridden when the action will be to fail, as
it will be here when we return -EINVAL.