netdev - Re: [PATCH 2/2] netlink: add ethernet address policy types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1537170327.2957.2.camel@sipsolutions.net>
Date:   Mon, 17 Sep 2018 09:45:27 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Michal Kubecek <mkubecek@...e.cz>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] netlink: add ethernet address policy types

On Thu, 2018-09-13 at 22:39 +0200, Michal Kubecek wrote:

> > What about
> > #define NLA_FIELD_ETH_ADDR  { .type = NLA_BINARY_EXACT, .len = ETH_ALEN }
> > 
> > Or even
> > #define NLA_FIELD_BINARY_EXACT(_len)	{ .type = NLA_BINARY_EXACT, .len = (_len) }
> > #define NLA_FIELD_ETH_ADDR		NLA_FIELD_BINARY_EXACT(ETH_ALEN)
> > 
> > So that one would just:
> >    [MYADDR] = NLA_FIELD_ETH_ADDR,
> 
> Yes, that's how I understoold Johannes' proposal above.

I was really thinking of

	[MYADDR] = { NLA_FIELD_ETH_ADDR },

but it doesn't really matter much to me either way.

johannes