netdev - Re: [PATCH] net: caif: remove redundant null check on frontpkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47b7f5a0-8b13-ead7-33b7-6e9c6ada8e61@cogentembedded.com>
Date:   Fri, 14 Sep 2018 20:54:26 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Colin King <colin.king@...onical.com>,
        Dmitry Tarnyagin <dmitry.tarnyagin@...kless.no>,
        "David S . Miller" <davem@...emloft.net>
Cc:     kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: caif: remove redundant null check on frontpkt

Hello!

On 09/14/2018 08:19 PM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> It is impossible for frontpkt to be null at the point of the null
> check because it has been assigned from rearpkt and there is no
> way realpkt can be null at the point of the assignment because

   rearpkt?

> of the sanity checking and exit paths taken previously. Remove
> the redundant null check.
> 
> Detected by CoverityScan, CID#114434 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
[...]

MBR, Sergei