netdev - Re: [PATCH] net: caif: remove redundant null check on frontpkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e80cfebd-3130-6b35-b878-219281de7cf3@canonical.com>
Date:   Fri, 14 Sep 2018 19:18:45 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Dmitry Tarnyagin <dmitry.tarnyagin@...kless.no>,
        "David S . Miller" <davem@...emloft.net>
Cc:     kernel-janitors@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] net: caif: remove redundant null check on frontpkt

On 14/09/18 18:54, Sergei Shtylyov wrote:
> Hello!
> 
> On 09/14/2018 08:19 PM, Colin King wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> It is impossible for frontpkt to be null at the point of the null
>> check because it has been assigned from rearpkt and there is no
>> way realpkt can be null at the point of the assignment because
> 
>    rearpkt?

Good spot. Can this be fixed up when the patch is applied?

> 
>> of the sanity checking and exit paths taken previously. Remove
>> the redundant null check.
>>
>> Detected by CoverityScan, CID#114434 ("Logically dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> [...]
> 
> MBR, Sergei
>