netdev - Re: [PATCH net-next] net: dsa: gswip: Fix return value check in gswip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f664c39-077b-ba9f-2651-71c45642a2b2@hauke-m.de>
Date:   Sat, 15 Sep 2018 11:14:13 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Wei Yongjun <weiyongjun1@...wei.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: gswip: Fix return value check in
 gswip_probe()

On 09/15/2018 03:33 AM, Wei Yongjun wrote:
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

> ---
>  drivers/net/dsa/lantiq_gswip.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 9c28d0b..faac359 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -1044,18 +1044,18 @@ static int gswip_probe(struct platform_device *pdev)
>  
>  	gswip_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	priv->gswip = devm_ioremap_resource(dev, gswip_res);
> -	if (!priv->gswip)
> -		return -ENOMEM;
> +	if (IS_ERR(priv->gswip))
> +		return PTR_ERR(priv->gswip);
>  
>  	mdio_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>  	priv->mdio = devm_ioremap_resource(dev, mdio_res);
> -	if (!priv->mdio)
> -		return -ENOMEM;
> +	if (IS_ERR(priv->mdio))
> +		return PTR_ERR(priv->mdio);
>  
>  	mii_res = platform_get_resource(pdev, IORESOURCE_MEM, 2);
>  	priv->mii = devm_ioremap_resource(dev, mii_res);
> -	if (!priv->mii)
> -		return -ENOMEM;
> +	if (IS_ERR(priv->mii))
> +		return PTR_ERR(priv->mii);
>  
>  	priv->hw_info = of_device_get_match_data(dev);
>  	if (!priv->hw_info)
> 




Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)