netdev - Re: [PATCH net-next] net: dsa: gswip: Fix copy-paste error in gswip_gphy_fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 15 Sep 2018 11:14:42 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Wei Yongjun <weiyongjun1@...wei.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: gswip: Fix copy-paste error in
 gswip_gphy_fw_probe()

On 09/15/2018 03:33 AM, Wei Yongjun wrote:
> The return value from of_reset_control_array_get_exclusive() is not
> checked correctly. The test is done against a wrong variable. This
> patch fix it.
> 
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Acked-by: Hauke Mehrtens <hauke@...ke-m.de>

> ---
>  drivers/net/dsa/lantiq_gswip.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 9c28d0b..9c10570 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -934,10 +934,10 @@ static int gswip_gphy_fw_probe(struct gswip_priv *priv,
>  	}
>  
>  	gphy_fw->reset = of_reset_control_array_get_exclusive(gphy_fw_np);
> -	if (IS_ERR(priv->gphy_fw)) {
> -		if (PTR_ERR(priv->gphy_fw) != -EPROBE_DEFER)
> +	if (IS_ERR(gphy_fw->reset)) {
> +		if (PTR_ERR(gphy_fw->reset) != -EPROBE_DEFER)
>  			dev_err(dev, "Failed to lookup gphy reset\n");
> -		return PTR_ERR(priv->gphy_fw);
> +		return PTR_ERR(gphy_fw->reset);
>  	}
>  
>  	return gswip_gphy_fw_load(priv, gphy_fw);
> 




Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)