netdev - Re: [PATCH net] ip6_tunnel: be careful when accessing the inner header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Sep 2018 21:25:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, glider@...gle.com
Subject: Re: [PATCH net] ip6_tunnel: be careful when accessing the inner
 header

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 19 Sep 2018 15:02:07 +0200

> the ip6 tunnel xmit ndo assumes that the processed skb always
> contains an ip[v6] header, but syzbot has found a way to send
> frames that fall short of this assumption, leading to the following splat:
 ...
> This change addresses the issue adding the needed check before
> accessing the inner header.
> 
> The ipv4 side of the issue is apparently there since the ipv4 over ipv6
> initial support, and the ipv6 side predates git history.
> 
> Fixes: c4d3efafcc93 ("[IPV6] IP6TUNNEL: Add support to IPv4 over IPv6 tunnel.")
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: syzbot+3fde91d4d394747d6db4@...kaller.appspotmail.com
> Tested-by: Alexander Potapenko <glider@...gle.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied and queued up for -stable.