netdev - Re: [PATCH net] net: mvneta: fix the Rx desc buffer DMA unmapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180919.212541.1251609826389428684.davem@davemloft.net>
Date:   Wed, 19 Sep 2018 21:25:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     antoine.tenart@...tlin.com
Cc:     yelena@...vell.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
        maxime.chevallier@...tlin.com, gregory.clement@...tlin.com,
        miquel.raynal@...tlin.com, nadavh@...vell.com, stefanc@...vell.com,
        ymarkman@...vell.com, mw@...ihalf.com
Subject: Re: [PATCH net] net: mvneta: fix the Rx desc buffer DMA unmapping

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Wed, 19 Sep 2018 15:29:06 +0200

> With CONFIG_DMA_API_DEBUG enabled we now get a warning when using the
> mvneta driver:
> 
>   mvneta d0030000.ethernet: DMA-API: device driver frees DMA memory with
>   wrong function [device address=0x000000001165b000] [size=4096 bytes]
>   [mapped as page] [unmapped as single]
> 
> This is because when using the s/w buffer management, the Rx descriptor
> buffer is mapped with dma_map_page but unmapped with dma_unmap_single.
> This patch fixes this by using the right unmapping function.
> 
> Fixes: 562e2f467e71 ("net: mvneta: Improve the buffer allocation method for SWBM")
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied.