netdev - Re: [PATCH v2 net-next] ravb: remove tx buffer addr 4byte alilgnment restriction for R-Car Gen3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60c73231-6e4a-5c18-139c-87d600967d97@cogentembedded.com>
Date:   Thu, 20 Sep 2018 11:36:23 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     David Miller <davem@...emloft.net>, horms+renesas@...ge.net.au
Cc:     magnus.damm@...il.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, kazuya.mizuguchi.ks@...esas.com
Subject: Re: [PATCH v2 net-next] ravb: remove tx buffer addr 4byte alilgnment
 restriction for R-Car Gen3

On 9/20/2018 7:08 AM, David Miller wrote:

>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>>
>> This patch sets from two descriptor to one descriptor because R-Car Gen3
>> does not have the 4 bytes alignment restriction of the transmission buffer.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>> Signed-off-by: Simon Horman <horms+renesas@...ge.net.au>
>> ---
>> v2 [Simon Horman]
>> * As per review by Sergi Shtylyov
>>    - Use reverse xmas tree for variable declarations
>>    - Use > rather than >= for conditions
>>    - Dropped unnecessary parentheses
>>    - Don't allocate memory for tx_align when it will not be used
>>    - But, kept NUM_TX_DESC_GEN[23] as I see some value in
>>      the self-documentation provided by these #defines
>>
>> v1 [Kazuya Mizuguchi]
> 
> Applied, thanks.

    Mhm, I was just going to re-review the patch...

MBR, Sergei