[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 19 Sep 2018 21:08:36 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: horms+renesas@...ge.net.au
Cc: sergei.shtylyov@...entembedded.com, magnus.damm@...il.com,
netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
kazuya.mizuguchi.ks@...esas.com
Subject: Re: [PATCH v2 net-next] ravb: remove tx buffer addr 4byte
alilgnment restriction for R-Car Gen3
From: Simon Horman <horms+renesas@...ge.net.au>
Date: Wed, 19 Sep 2018 10:06:21 +0200
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
>
> This patch sets from two descriptor to one descriptor because R-Car Gen3
> does not have the 4 bytes alignment restriction of the transmission buffer.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@...esas.com>
> Signed-off-by: Simon Horman <horms+renesas@...ge.net.au>
> ---
> v2 [Simon Horman]
> * As per review by Sergi Shtylyov
> - Use reverse xmas tree for variable declarations
> - Use > rather than >= for conditions
> - Dropped unnecessary parentheses
> - Don't allocate memory for tx_align when it will not be used
> - But, kept NUM_TX_DESC_GEN[23] as I see some value in
> the self-documentation provided by these #defines
>
> v1 [Kazuya Mizuguchi]
Applied, thanks.
Powered by blists - more mailing lists