netdev - Re: [PATCH net] net: diag: Fix swapped src/dst in udp_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKD1Yr3cAK-wqM4V=evm8_CV_PLh0RUhu-AjJP=PZF5kAypJbA@mail.gmail.com>
Date:   Fri, 21 Sep 2018 18:46:25 +0800
From:   Lorenzo Colitti <lorenzo@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        Maciej Żenczykowski <zenczykowski@...il.com>,
        David Ahern <dsahern@...il.com>,
        Jeffrey Vander Stoep <jeffv@...gle.com>
Subject: Re: [PATCH net] net: diag: Fix swapped src/dst in udp_dump_one.

On Fri, Sep 14, 2018 at 11:30 PM David Miller <davem@...emloft.net> wrote:
> Unfortunately I think we are stuck with how things are now.
>
> Indisputably, your patch breaks userland components that have
> workarounds in order to work with existing kernels.  [...]
> I cannot apply this, sorry.

Understood. We're about to start using this UDP codepath on Android,
so I wanted to see if this would be fixed before we commit to the
current behaviour in our conformance tests, at which point we won't
ever be able to change it either.

Would you take a patch to add a one-line comment saying that this is
the way it is for backwards compatibility? If that comment were there
anyone else who finds this will not spend time debugging it and
immediately know what's going on. The fact that the ports are inverted
is not easy to spot on casual inspection.