[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20180921.074907.896069317193269306.davem@davemloft.net>
Date: Fri, 21 Sep 2018 07:49:07 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: lorenzo@...gle.com
Cc: netdev@...r.kernel.org, zenczykowski@...il.com, dsahern@...il.com,
jeffv@...gle.com
Subject: Re: [PATCH net] net: diag: Fix swapped src/dst in udp_dump_one.
From: Lorenzo Colitti <lorenzo@...gle.com>
Date: Fri, 21 Sep 2018 18:46:25 +0800
> Would you take a patch to add a one-line comment saying that this is
> the way it is for backwards compatibility? If that comment were there
> anyone else who finds this will not spend time debugging it and
> immediately know what's going on. The fact that the ports are inverted
> is not easy to spot on casual inspection.
Sure.
Powered by blists - more mailing lists