netdev - Re: [PATCH net-next 00/22] net: fix return type of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83d29681-b008-9b1f-5961-e23f0174d5f4@huawei.com>
Date:   Fri, 21 Sep 2018 09:33:24 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <dmitry.tarnyagin@...kless.no>, <wg@...ndegger.com>,
        <mkl@...gutronix.de>, <michal.simek@...inx.com>,
        <hsweeten@...ionengravers.com>, <madalin.bucur@....com>,
        <pantelis.antoniou@...il.com>, <claudiu.manoil@....com>,
        <leoyang.li@....com>, <linux@...linux.org.uk>, <sammy@...my.net>,
        <ralf@...ux-mips.org>, <nico@...xnic.net>,
        <steve.glendinning@...well.net>, <f.fainelli@...il.com>,
        <grygorii.strashko@...com>, <w-kwok2@...com>,
        <m-karicheri2@...com>, <t.sailer@...mni.ethz.ch>,
        <jreuter@...na.de>, <kys@...rosoft.com>, <haiyangz@...rosoft.com>,
        <wei.liu2@...rix.com>, <paul.durrant@...rix.com>,
        <arvid.brodin@...en.se>, <pshelar@....org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-can@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-mips@...ux-mips.org>,
        <linux-omap@...r.kernel.org>, <linux-hams@...r.kernel.org>,
        <devel@...uxdriverproject.org>, <linux-usb@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <dev@...nvswitch.org>
Subject: Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit
 function

On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
> 
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
> 
> I would advise you not to send so many of these changes as a group.
> 
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
> 

Yes, I will send it separately after test and review again.

Thank you for your advice.

> .
>