netdev - Re: [PATCH net-next 00/22] net: fix return type of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46f95cf9-8f8f-e3ab-3142-947faeee9fa9@ti.com>
Date:   Thu, 20 Sep 2018 12:04:58 -0500
From:   Grygorii Strashko <grygorii.strashko@...com>
To:     YueHaibing <yuehaibing@...wei.com>, <davem@...emloft.net>,
        <dmitry.tarnyagin@...kless.no>, <wg@...ndegger.com>,
        <mkl@...gutronix.de>, <michal.simek@...inx.com>,
        <hsweeten@...ionengravers.com>, <madalin.bucur@....com>,
        <pantelis.antoniou@...il.com>, <claudiu.manoil@....com>,
        <leoyang.li@....com>, <linux@...linux.org.uk>, <sammy@...my.net>,
        <ralf@...ux-mips.org>, <nico@...xnic.net>,
        <steve.glendinning@...well.net>, <f.fainelli@...il.com>,
        <w-kwok2@...com>, <m-karicheri2@...com>, <t.sailer@...mni.ethz.ch>,
        <jreuter@...na.de>, <kys@...rosoft.com>, <haiyangz@...rosoft.com>,
        <wei.liu2@...rix.com>, <paul.durrant@...rix.com>,
        <arvid.brodin@...en.se>, <pshelar@....org>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-can@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-mips@...ux-mips.org>,
        <linux-omap@...r.kernel.org>, <linux-hams@...r.kernel.org>,
        <devel@...uxdriverproject.org>, <linux-usb@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <dev@...nvswitch.org>
Subject: Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit
 function



On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
> 

May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().

-- 
regards,
-grygorii