netdev - Re: [PATCH net-next] dt-bindings: net: ravb: Add support for r8a7744 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180924084542.qcvb4uykzqel3uu7@verge.net.au>
Date:   Mon, 24 Sep 2018 10:45:42 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Biju Das <biju.das@...renesas.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Fabrizio Castro <fabrizio.castro@...renesas.com>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>
Subject: Re: [PATCH net-next] dt-bindings: net: ravb: Add support for r8a7744
 SoC

On Fri, Sep 21, 2018 at 03:57:33PM +0000, Biju Das wrote:
> Hi Sergei,
> 
> Thanks  for the feedback.
> 
> > Subject: Re: [PATCH net-next] dt-bindings: net: ravb: Add support for
> > r8a7744 SoC
> >
> > Hello!
> >
> > On 09/21/2018 05:25 PM, Biju Das wrote:
> >
> > > Document RZ/G1N (R8A7744) SoC bindings.
> > >
> > > Signed-off-by: Biju Das <biju.das@...renesas.com>
> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@...renesas.com>
> >
> > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> >
> > > ---
> > >  Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > > index da249b7..3530256 100644
> > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt
> > > @@ -6,6 +6,7 @@ interface contains.
> > >  Required properties:
> > >  - compatible: Must contain one or more of the following:
> > >        - "renesas,etheravb-r8a7743" for the R8A7743 SoC.
> > > +      - "renesas,etheravb-r8a7744" for the R8A7744 SoC.
> >
> >    Mmm, I thought it was decided to go with the full model #s, like with
> > R8A77470 below?
> 
> For RZ/G1C case, there are 2 variants 1 with HDMI(R8A77470) and the other without HDMI(R8A77471).
> Current support is for R8A77470.

r8a7744 is consistent with other bindings for this SoC and my understanding
is that it is a) sufficient to differentiate this SoC and b) in keeping
with most other RZ/G1 SoCs (RZ/G1C being the exception).

In short, this seems fine to me.

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> > >        - "renesas,etheravb-r8a7745" for the R8A7745 SoC.
> > >        - "renesas,etheravb-r8a77470" for the R8A77470 SoC.
> > >        - "renesas,etheravb-r8a7790" for the R8A7790 SoC.