netdev - Re: [PATCH net-next 9/9] net: bridge: pack net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180926133014.GA31563@splinter>
Date:   Wed, 26 Sep 2018 16:30:14 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        davem@...emloft.net, stephen@...workplumber.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 9/9] net: bridge: pack net_bridge better

On Wed, Sep 26, 2018 at 03:18:02PM +0300, Nikolay Aleksandrov wrote:
> Further reduce the size of net_bridge with 8 bytes and reduce the number of
> holes in it:
>  Before: holes: 5, sum holes: 15
>  After: holes: 2, sum holes: 3
> 
> Also as a bonus we get offload_fwd_mark in the first cache line and remove
> the need to pull the last cache line of net_bridge just for that member in
> fast path (should_deliver -> nbp_switchdev_allowed_egress).

But nbp_switchdev_allowed_egress() compares with 'offload_fwd_mark' from
'net_bridge_port', not 'net_bridge'...