netdev - Re: [PATCH net-next 9/9] net: bridge: pack net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54917489-964b-76b3-82c7-a82b41d474b2@cumulusnetworks.com>
Date:   Wed, 26 Sep 2018 16:35:49 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        davem@...emloft.net, stephen@...workplumber.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 9/9] net: bridge: pack net_bridge better

On 26/09/18 16:30, Ido Schimmel wrote:
> On Wed, Sep 26, 2018 at 03:18:02PM +0300, Nikolay Aleksandrov wrote:
>> Further reduce the size of net_bridge with 8 bytes and reduce the number of
>> holes in it:
>>  Before: holes: 5, sum holes: 15
>>  After: holes: 2, sum holes: 3
>>
>> Also as a bonus we get offload_fwd_mark in the first cache line and remove
>> the need to pull the last cache line of net_bridge just for that member in
>> fast path (should_deliver -> nbp_switchdev_allowed_egress).
> 
> But nbp_switchdev_allowed_egress() compares with 'offload_fwd_mark' from
> 'net_bridge_port', not 'net_bridge'...
> 

ha, right you are! I need to check my glasses :) Anyway, I'll correct my
commit message and resend v2. We can leave the net_bridge mark in the
end, there're 4 bytes there anyway.

I was thinking of net_bridge_port, but that is a different patch-set I
have. Apparently I've mixed the commit messages.

Thanks!