netdev - Re: [PATCH net-next 2/9] net: bridge: add bitfield for options and convert vlan opts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180926144808.GM1676@lunn.ch>
Date:   Wed, 26 Sep 2018 16:48:08 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        davem@...emloft.net, stephen@...workplumber.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next 2/9] net: bridge: add bitfield for options and
 convert vlan opts

Hi Nikolay

>  struct net_bridge {
>  	spinlock_t			lock;
>  	spinlock_t			hash_lock;
>  	struct list_head		port_list;
>  	struct net_device		*dev;
>  	struct pcpu_sw_netstats		__percpu *stats;
> +	unsigned long			options;

Maybe a u32 would be better, so we run out of bits at the same time on
32 and 64 bit systems?

   Andrew