netdev - Re: [PATCH net-next] net: ethernet: dpaa: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180926.103506.950692305206471144.davem@davemloft.net>
Date:   Wed, 26 Sep 2018 10:35:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     madalin.bucur@....com, andrew@...n.ch, f.fainelli@...il.com,
        yangbo.lu@....com, mail@...emoroni.com, gustavo@...eddedor.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: dpaa: remove unused variables

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 26 Sep 2018 15:12:13 +0200

> The patch that removed the only users of the oldadv/newadv variables
> accidentally left the now-unused declarations behind:
> 
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c: In function 'dpaa_set_pauseparam':
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:14: error: unused variable 'oldadv' [-Werror=unused-variable]
> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:185:6: error: unused variable 'newadv' [-Werror=unused-variable]
> 
> Fixes: 70814e819c11 ("net: ethernet: Add helper for set_pauseparam for Asym Pause")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.