netdev - Re: [PATCH net-next] net: phy: mdio-bcm-unimac: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180926.103627.366696832700107636.davem@davemloft.net>
Date:   Wed, 26 Sep 2018 10:36:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     andrew@...n.ch, f.fainelli@...il.com, weiyongjun1@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: mdio-bcm-unimac: mark PM functions
 as __maybe_unused

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 26 Sep 2018 15:14:10 +0200

> The newly added runtime-pm support causes a harmless warning
> when CONFIG_PM is disabled:
> 
> drivers/net/phy/mdio-bcm-unimac.c:330:12: error: 'unimac_mdio_resume' defined but not used [-Werror=unused-function]
>  static int unimac_mdio_resume(struct device *d)
> drivers/net/phy/mdio-bcm-unimac.c:321:12: error: 'unimac_mdio_suspend' defined but not used [-Werror=unused-function]
>  static int unimac_mdio_suspend(struct device *d)
> 
> Marking the functions as __maybe_unused is the easiest workaround
> and avoids adding #ifdef checks.
> 
> Fixes: b78ac6ecd1b6 ("net: phy: mdio-bcm-unimac: Allow configuring MDIO clock divider")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.