netdev - Re: [PATCH net 01/11] netpoll: do not test NAPI_STATE_SCHED in poll_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BBFADC0E-E9AE-42A2-B87C-FDEFA074E4F1@fb.com>
Date:   Thu, 27 Sep 2018 18:33:59 +0000
From:   Song Liu <songliubraving@...com>
To:     Michael Chan <michael.chan@...adcom.com>
CC:     Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        "aviad.krawczyk@...wei.com" <aviad.krawczyk@...wei.com>,
        "dougmill@...ux.vnet.ibm.com" <dougmill@...ux.vnet.ibm.com>,
        "yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "harish.patil@...ium.com" <harish.patil@...ium.com>,
        "Chopra, Manish" <manish.chopra@...ium.com>,
        "netanel@...zon.com" <netanel@...zon.com>,
        "linux-net-drivers@...arflare.com" <linux-net-drivers@...arflare.com>,
        "tlfalcon@...ux.vnet.ibm.com" <tlfalcon@...ux.vnet.ibm.com>
Subject: Re: [PATCH net 01/11] netpoll: do not test NAPI_STATE_SCHED in
 poll_one_napi()



> On Sep 27, 2018, at 11:25 AM, Michael Chan <michael.chan@...adcom.com> wrote:
> 
> On Thu, Sep 27, 2018 at 9:32 AM Eric Dumazet <edumazet@...gle.com> wrote:
>> 
>> Since we do no longer require NAPI drivers to provide
>> an ndo_poll_controller(), napi_schedule() has not been done
>> before poll_one_napi() invocation.
>> 
>> So testing NAPI_STATE_SCHED is likely to cause early returns.
>> 
>> While we are at it, remove outdated comment.
>> 
>> Note to future bisections : This change might surface prior
>> bugs in drivers. See commit 73f21c653f93 ("bnxt_en: Fix TX
>> timeout during netpoll.") for one occurrence.
>> 
>> Fixes: ac3d9dd034e5 ("netpoll: make ndo_poll_controller() optional")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Tested-by: Song Liu <songliubraving@...com>
>> Cc: Michael Chan <michael.chan@...adcom.com>
> 
> Reviewed-and-tested-by: Michael Chan <michael.chan@...adcom.com>

Reviewed-and-tested-by: Song Liu <songliubraving@...com>