netdev - Re: [PATCH 1/1] bridge: remove BR_GROUPFWD_RESTRICTED for arbitrary forwarding of reserved addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <102873a5-ed43-2bf7-9ef7-70a76c5b7f6e@cumulusnetworks.com>
Date:   Tue, 2 Oct 2018 19:10:49 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Richard Weinberger <richard@....at>
Cc:     Ido Schimmel <idosch@...sch.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        bernhard.thaler@...et.at, "David S. Miller" <davem@...emloft.net>,
        bridge@...ts.linux-foundation.org, netdev@...r.kernel.org,
        David Gstir <david@...ma-star.at>, roopa@...ulusnetworks.com
Subject: Re: [PATCH 1/1] bridge: remove BR_GROUPFWD_RESTRICTED for arbitrary
 forwarding of reserved addresses

On 02/10/2018 18:56, Richard Weinberger wrote:
> Nikolay,
> 
> Am Dienstag, 2. Oktober 2018, 16:59:31 CEST schrieb Nikolay Aleksandrov:
>> Richard please check commit:
>> commit 5af48b59f35c
>> Author: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
>> Date:   Wed Sep 27 16:12:44 2017 +0300
>>
>>     net: bridge: add per-port group_fwd_mask with less restrictions
>>     
>>     We need to be able to transparently forward most link-local frames via
>>     tunnels (e.g. vxlan, qinq). Currently the bridge's group_fwd_mask has a
>>     mask which restricts the forwarding of STP and LACP, but we need to be able
>>     to forward these over tunnels and control that forwarding on a per-port
>>     basis thus add a new per-port group_fwd_mask option which only disallows
>>     mac pause frames to be forwarded (they're always dropped anyway).
>>     The patch does not change the current default situation - all of the others
>>     are still restricted unless configured for forwarding.
>>     We have successfully tested this patch with LACP and STP forwarding over
>>     VxLAN and qinq tunnels.
>>     
>>     Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
>>     Signed-off-by: David S. Miller <davem@...emloft.net>
>>
>>
>> Will this work for you ?
>> It's in the bridge since v4.15.
> 
> Hmm, I *think* this is exactly what I need.
> To understand it correctly, I have to set per port group_fwd_mask for both slaves
> of the bridge then it will forward anything (except for PAUSE frames)?
> 

Yes, that is the expected behaviour.

> Is there a reason why this knob is not documented in Documentation/ABI/testing/sysfs-class-net?
> 

Hmm, I don't think any of the bridge knobs are documented there or any other master device for that
matter. Most of these options are documented in ip-link.8 man page from iproute2, it seems though
this one I've missed to document. I'll prepare a patch for iproute2.
 
> Thanks,
> //richard
> 
> 
>