netdev - Re: [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181002.112600.2116388713222602539.davem@davemloft.net>
Date:   Tue, 02 Oct 2018 11:26:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mmanning@...tta.att-mail.com
Cc:     netdev@...r.kernel.org, fw@...len.de
Subject: Re: [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test
 results

From: Mike Manning <mmanning@...tta.att-mail.com>
Date: Tue,  2 Oct 2018 12:40:30 +0100

> This reverts commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags
> smaller than min mtu"). While one should not get fragments smaller than
> the IPv6 minimum MTU, not handling crafted packets in the TAHI IPv6
> conformance test suite (v6eval) for IPv6 Ready Logo results in 18
> failures representing over 5% of the score.
> 
> Cc: Florian Westphal <fw@...len.de>
> Signed-off-by: Mike Manning <mmanning@...tta.att-mail.com>

Sorry, I'm not just going to blindly apply a patch because some
TAHI tests fail.

It's possible the TAHI tests are wrong, or that the specification
elements it is testing don't make any sense these days.

Allowing all kinds of random junk in the middle of the fragment queue
leads to lots of unnecessary cpu overhead and potential bugs, and it
triggerable remotely.