netdev - RE: [net-next 08/15] ice: Notify VF of link status change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CFEEE81102D91947B9CC368106979EBAAA66196E@FMSMSX152.amr.corp.intel.com>
Date:   Thu, 4 Oct 2018 17:36:43 +0000
From:   "Abodunrin, Akeem G" <akeem.g.abodunrin@...el.com>
To:     Or Gerlitz <gerlitz.or@...il.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     David Miller <davem@...emloft.net>,
        "Venkataramanan, Anirudh" <anirudh.venkataramanan@...el.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [net-next 08/15] ice: Notify VF of link status change

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Or Gerlitz
> Sent: Wednesday, October 03, 2018 10:23 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Cc: David Miller <davem@...emloft.net>; Venkataramanan, Anirudh
> <anirudh.venkataramanan@...el.com>; Linux Netdev List
> <netdev@...r.kernel.org>; nhorman@...hat.com; sassmann@...hat.com
> Subject: Re: [net-next 08/15] ice: Notify VF of link status change
> 
> On Wed, Oct 3, 2018 at 6:46 PM Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> wrote:
> > From: Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
> >
> > When PF gets a link status change event, notify the VFs of the same.
> 
> so you always want to block east/west traffic when the uplink is down? why?
> 
> The correct approach is to have vf/vport e-switch representor on the host, and if
> the host admin puts down the administrative link of the rep -- the vf operational
> link (carrier) goes down.

This code, notifying VFs of PF link event does not include scenario for e-switch VF port representor - the function will be expanded in the separate patches for switchdev supports...
That being said, this is design to notify VF when PF link changes, may be due to reset, administrative link down, forced link speed... and yes, this will stop east/west traffic, but admin can force VFs (associated with that PF) link up on the host with "ip" command, and east/west traffic will resume.
In the future patch for VF port representor -  if the host admin puts down the administrative link of the rep -- the vf operational link (carrier) goes down... just as you said.

Please let us know if you have additional question.

Thanks,
~Akeem