netdev - Re: [net-next 02/13] ixgbe: Fix ixgbe TX hangs with XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <393d262e-ce4a-a786-a3bb-82ef73879d4c@cogentembedded.com>
Date:   Thu, 4 Oct 2018 12:08:49 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     Radoslaw Tyl <radoslawx.tyl@...el.com>, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 02/13] ixgbe: Fix ixgbe TX hangs with XDP_TX beyond
 queue limit

Hello!

On 10/3/2018 11:25 PM, Jeff Kirsher wrote:

> From: Radoslaw Tyl <radoslawx.tyl@...el.com>
> 
> We have Tx hang when number Tx and XDP queues are more than 64.
                              ^ of

> In XDP always is MTQC == 0x0 (64TxQs). We need more space for Tx queues.
> 
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 14 ++++++++++----
>   1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index 140e87a10ff5..ddc22557155b 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -3577,12 +3577,18 @@ static void ixgbe_setup_mtqc(struct ixgbe_adapter *adapter)
>   		else
>   			mtqc |= IXGBE_MTQC_64VF;
>   	} else {
> -		if (tcs > 4)
> +		if (tcs > 4) {
>   			mtqc = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_8TC_8TQ;
> -		else if (tcs > 1)
> +		} else if (tcs > 1) {
>   			mtqc = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_4TC_4TQ;
> -		else
> -			mtqc = IXGBE_MTQC_64Q_1PB;
> +		} else {
> +			u8 max_txq = adapter->num_tx_queues +
> +				adapter->num_xdp_queues;

    Empty line needed here, after declaration.

> +			if (max_txq > 63)
> +				mtqc = IXGBE_MTQC_RT_ENA | IXGBE_MTQC_4TC_4TQ;
> +			else
> +				mtqc = IXGBE_MTQC_64Q_1PB;
> +		}
>   	}
>   
>   	IXGBE_WRITE_REG(hw, IXGBE_MTQC, mtqc);

MBR, Sergei