netdev - Re: [net-next 07/13] ixgbe: Fix crash with VFs and flow director on interface flap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5437a9a-65c5-16a3-7606-e75c30113882@cogentembedded.com>
Date:   Thu, 4 Oct 2018 12:12:36 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     Radoslaw Tyl <radoslawx.tyl@...el.com>, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 07/13] ixgbe: Fix crash with VFs and flow director on
 interface flap

Hello!

On 10/3/2018 11:25 PM, Jeff Kirsher wrote:

> From: Radoslaw Tyl <radoslawx.tyl@...el.com>
> 
> This patch fix crash when we have restore flow director filters after reset

    Fixes. Restored?

> adapter. In ixgbe_fdir_filter_restore() filter->action is outside of the
> rx_ring array, as it has a VF identifier in the upper 32 bits.
> 
> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@...el.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>   drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index ddc22557155b..2928ce7653eb 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
[...]
> @@ -5187,12 +5188,17 @@ static void ixgbe_fdir_filter_restore(struct ixgbe_adapter *adapter)
>   
>   	hlist_for_each_entry_safe(filter, node2,
>   				  &adapter->fdir_filter_list, fdir_node) {
> +		action = filter->action;
> +		if (action != IXGBE_FDIR_DROP_QUEUE && action != 0)
> +			action =
> +			(action >> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF) - 1;

    Could you indent with extra tab here?

[...]

MBR, Sergei