netdev - Re: [PATCH net] net: sched: Add policy validation for tc attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181005.142712.1319668539769973294.davem@davemloft.net>
Date:   Fri, 05 Oct 2018 14:27:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com,
        xiyou.wangcong@...il.com, jhs@...atatu.com, dsahern@...il.com
Subject: Re: [PATCH net] net: sched: Add policy validation for tc attributes

From: David Ahern <dsahern@...nel.org>
Date: Wed,  3 Oct 2018 15:05:36 -0700

> From: David Ahern <dsahern@...il.com>
> 
> A number of TC attributes are processed without proper validation
> (e.g., length checks). Add a tca policy for all input attributes and use
> when invoking nlmsg_parse.
> 
> The 2 Fixes tags below cover the latest additions. The other attributes
> are a string (KIND), nested attribute (OPTIONS which does seem to have
> validation in most cases), for dumps only or a flag.
> 
> Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters")
> Fixes: d47a6b0e7c492 ("net: sched: introduce ingress/egress block index attributes for qdisc")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks David.