netdev - Re: [PATCH net] be2net: don't flip hw_features when VXLANs are added/deleted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181005.005944.676060322932993396.davem@davemloft.net>
Date:   Fri, 05 Oct 2018 00:59:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     netdev@...r.kernel.org, sriharsha.basavapatna@...adcom.com,
        ajit.khaparde@...adcom.com, sathya.perla@...adcom.com,
        sd@...asysnail.net
Subject: Re: [PATCH net] be2net: don't flip hw_features when VXLANs are
 added/deleted

From: Davide Caratti <dcaratti@...hat.com>
Date: Wed,  3 Oct 2018 15:20:58 +0200

> the be2net implementation of .ndo_tunnel_{add,del}() changes the value of
> NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets
> to call netdev_features_change(). Moreover, ethtool setting for that bit
> can potentially be reverted after a tunnel is added or removed.
> 
> GSO already does software segmentation when 'hw_enc_features' is 0, even
> if VXLAN offload is turned on. In addition, commit 096de2f83ebc ("benet:
> stricter vxlan offloading check in be_features_check") avoids hardware
> segmentation of non-VXLAN tunneled packets, or VXLAN packets having wrong
> destination port. So, it's safe to avoid flipping the above feature on
> addition/deletion of VXLAN tunnels.
> 
> Fixes: 630f4b70567f ("be2net: Export tunnel offloads only when a VxLAN tunnel is created")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied, thank you.