netdev - Re: [PATCH v2] net: phy: phylink: fix SFP interface autodetection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181005.010509.468706187273505393.davem@davemloft.net>
Date:   Fri, 05 Oct 2018 01:05:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     baruch@...s.co.il
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux@...linux.org.uk, antoine.tenart@...tlin.com,
        gregory.clement@...tlin.com, ori.shemtov@...id-run.com
Subject: Re: [PATCH v2] net: phy: phylink: fix SFP interface autodetection

From: Baruch Siach <baruch@...s.co.il>
Date: Wed,  3 Oct 2018 19:04:49 +0300

> When connecting SFP PHY to phylink use the detected interface.
> Otherwise, the link fails to come up when the configured 'phy-mode'
> differs from the SFP detected mode.
> 
> Move most of phylink_connect_phy() into __phylink_connect_phy(), and
> leave phylink_connect_phy() as a wrapper. phylink_sfp_connect_phy() can
> now pass the SFP detected PHY interface to __phylink_connect_phy().
> 
> This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that
> is configured in the DT to "2500base-x" phy-mode.
> 
> Fixes: 9525ae83959b6 ("phylink: add phylink infrastructure")
> Suggested-by: Russell King <rmk+kernel@...linux.org.uk>
> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
> v2: Leave the phylink_connect_phy() functionality unchanged. Only
>     phylink_sfp_connect_phy() calls __phylink_connect_phy() with the
>     detected interface (Russell King)

Applied and queued up for -stable.