netdev - Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 08 Oct 2018 10:46:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rppt@...ux.vnet.ibm.com
Cc:     dsahern@...il.com, netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6
 info

From: Mike Rapoport <rppt@...ux.vnet.ibm.com>
Date: Mon,  8 Oct 2018 15:06:03 +0300

> The fib6_info_alloc() function allocates percpu memory to hold per CPU
> pointers to rt6_info, but this memory is never freed. Fix it.
> 
> Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers")
> 

Please do not put empty lines between Fixes: and other tags.  They
belong together as a group.

> Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> Cc: stable@...r.kernel.org

Several problems here.

You cannot submit patches to net-next and expect them to go onward to
-stable.  That is not appropriate.  If it is going to stable, you
must target 'net' not 'net-next'.

Furthermore, for networking changes, explicit CC: of stable is not
appropriate.  Instead you must explicitly ask me to queue the patch
up for -stable as I handle networking stable submissions myself.

Thank you.