netdev - Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6 info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b36e7c9-0f9b-64c4-f7d6-1d1a92097eaa@gmail.com>
Date:   Mon, 8 Oct 2018 12:15:54 -0600
From:   David Ahern <dsahern@...il.com>
To:     Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net-next] net/ipv6: stop leaking percpu memory in fib6
 info

On 10/8/18 6:06 AM, Mike Rapoport wrote:
> The fib6_info_alloc() function allocates percpu memory to hold per CPU
> pointers to rt6_info, but this memory is never freed. Fix it.
> 
> Fixes: a64efe142f5e ("net/ipv6: introduce fib6_info struct and helpers")
> 
> Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> Cc: stable@...r.kernel.org
> ---
>  net/ipv6/ip6_fib.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
> index cf709eadc932..cc7de7eb8b9c 100644
> --- a/net/ipv6/ip6_fib.c
> +++ b/net/ipv6/ip6_fib.c
> @@ -194,6 +194,8 @@ void fib6_info_destroy_rcu(struct rcu_head *head)
>  				*ppcpu_rt = NULL;
>  			}
>  		}
> +
> +		free_percpu(f6i->rt6i_pcpu);
>  	}
>  
>  	lwtstate_put(f6i->fib6_nh.nh_lwtstate);
> 

Odd that KMEMLEAK is not detecting this. Thanks for the fix.

Reviewed-by: David Ahern <dsahern@...il.com>