netdev - Re: [PATCH net 2/2] geneve, vxlan: Don't set exceptions if skb->len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181015102716.2a56623f@redhat.com>
Date:   Mon, 15 Oct 2018 10:27:16 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     davem <davem@...emloft.net>, Sabrina Dubroca <sd@...asysnail.net>,
        network dev <netdev@...r.kernel.org>
Subject: Re: [PATCH net 2/2] geneve, vxlan: Don't set exceptions if skb->len
 < mtu

On Mon, 15 Oct 2018 15:01:31 +0900
Xin Long <lucien.xin@...il.com> wrote:

> On Sat, Oct 13, 2018 at 6:54 AM Stefano Brivio <sbrivio@...hat.com> wrote:
> >
> > We shouldn't abuse exceptions: if the destination MTU is already higher
> > than what we're transmitting, no exception should be created.  
> makes sense, shouldn't ip(6) tunnels also do this?

I should probably have mentioned this in the cover letter: in theory
yes, but I'm doing this as preparation for ICMP handling in UDP
tunnels, and those will get selftests soon (once I'm done).

Writing extensive selftests for IP tunnels will take significantly
longer, so I'm not too confident to change this right now. I'd prefer
to address that at a later time.

-- 
Stefano