netdev - Re: [PATCH] net: bridge: fix a memory leak in __vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJFZqHznOMCyBWPd68LiF3gVM8-Y81_iydzVXj43KxG=wEANBA@mail.gmail.com>
Date:   Mon, 15 Oct 2018 16:31:05 +0800
From:   Li RongQing <roy.qing.li@...il.com>
To:     nikolay@...ulusnetworks.com
Cc:     Li RongQing <lirongqing@...du.com>,
        netdev <netdev@...r.kernel.org>,
        bridge@...ts.linux-foundation.org, roopa@...ulusnetworks.com
Subject: Re: [PATCH] net: bridge: fix a memory leak in __vlan_add

> >
>
> Hi,
> Good catch, but the patch doesn't fix the bug entirely. The problem is that masterv can be
> created just for this vlan and the br_vlan_put_master() above can free it, so we can
> check a pointer that's not really up-to-date (and thus again leak memory).
> You should move the new code above the br_vlan_put_master() call.
>
> Also please tag the proper branch, this is for net-next, and CC all bridge
> maintainers (added Roopa).
>

Ok, thanks, I will send v2

-RongQing


> Thank you,
>  Nik