netdev - Re: [PATCH net-next] tun: Consistently configure generic netdev params via rtnetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015.214128.1239999224981119173.davem@davemloft.net>
Date:   Mon, 15 Oct 2018 21:41:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     serhe.popovych@...il.com
Cc:     netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [PATCH net-next] tun: Consistently configure generic netdev
 params via rtnetlink

From: Serhey Popovych <serhe.popovych@...il.com>
Date: Tue,  9 Oct 2018 21:21:01 +0300

> Configuring generic network device parameters on tun will fail in
> presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute
> since tun_validate() always return failure.
> 
> This can be visualized with following ip-link(8) command sequences:
> 
>   # ip link set dev tun0 group 100
>   # ip link set dev tun0 group 100 type tun
>   RTNETLINK answers: Invalid argument
> 
> with contrast to dummy and veth drivers:
> 
>   # ip link set dev dummy0 group 100
>   # ip link set dev dummy0 type dummy
> 
>   # ip link set dev veth0 group 100
>   # ip link set dev veth0 group 100 type veth
> 
> Fix by returning zero in tun_validate() when @data is NULL that is
> always in case since rtnl_link_ops->maxtype is zero in tun driver.
> 
> Fixes: f019a7a594d9 ("tun: Implement ip link del tunXXX")
> Signed-off-by: Serhey Popovych <serhe.popovych@...il.com>

Applied, thank you.