netdev - Re: [PATCH net] net: ipmr: fix unresolved entry dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec18010b-cd8a-f419-a929-c0b1a0a09928@gmail.com>
Date:   Thu, 18 Oct 2018 09:16:17 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Miller <davem@...emloft.net>, nikolay@...ulusnetworks.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ipmr: fix unresolved entry dumps

On 10/17/18 11:36 PM, David Miller wrote:
> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> Date: Wed, 17 Oct 2018 22:34:34 +0300
> 
>> If the skb space ends in an unresolved entry while dumping we'll miss
>> some unresolved entries. The reason is due to zeroing the entry counter
>> between dumping resolved and unresolved mfc entries. We should just
>> keep counting until the whole table is dumped and zero when we move to
>> the next as we have a separate table counter.
>>
>> Reported-by: Colin Ian King <colin.king@...onical.com>
>> Fixes: 8fb472c09b9d ("ipmr: improve hash scalability")
>> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> Applied and queued up for -stable.
> 

FYI: on the net to net-next merge, those 2 lines were moved to
mr_table_dump.