netdev - RE: [PATCH net-next] netpoll: allow cleanup to be synchronous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Oct 2018 15:17:06 +0000
From:   "Banerjee, Debabrata" <dbanerje@...mai.com>
To:     'Neil Horman' <nhorman@...driver.com>,
        David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] netpoll: allow cleanup to be synchronous

> From: Neil Horman <nhorman@...driver.com>

> Agreed, this doesn't make sense.  If you want a synchronous cleanup, create
> a wrapper function that creates a wait queue, calls __netpoll_free_async,
> and blocks on the wait queue completion.  Modify the cleanup_work
> method(s) to complete the wait queue, and you've got what you want.
> 
> Neil

Actually the patch looks bad, but it seems to turn out the rtnl is always
held by the parent when it is called, and asynchronous cleanup doesn't
seem to be necessary at all. Perhaps you could share your deadlock
test case for 2cde6acd49da?

Patch v2 coming next.

-Deb