netdev - Re: [PATCH net] Revert "neighbour: force neigh_invalidate when NUD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181020.222657.731816296109784832.davem@davemloft.net>
Date:   Sat, 20 Oct 2018 22:26:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     roopa@...ulusnetworks.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] Revert "neighbour: force neigh_invalidate when
 NUD_FAILED update is from admin"

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Sat, 20 Oct 2018 18:09:31 -0700

> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> This reverts commit 8e326289e3069dfc9fa9c209924668dd031ab8ef.
> 
> This patch results in unnecessary netlink notification when one
> tries to delete a neigh entry already in NUD_FAILED state. Found
> this with a buggy app that tries to delete a NUD_FAILED entry
> repeatedly. While the notification issue can be fixed with more
> checks, adding more complexity here seems unnecessary. Also,
> recent tests with other changes in the neighbour code have
> shown that the INCOMPLETE and PROBE checks are good enough for
> the original issue.
> 
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Applied, thanks.