netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 Oct 2018 22:26:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     akpm@...ux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [GIT] Networking

From: David Miller <davem@...emloft.net>
Date: Sat, 20 Oct 2018 15:47:37 -0700 (PDT)

> 
> A few straggler bug fixes:
> 
> 1) Fix indexing of multi-pass dumps of ipv6 addresses, from David
>    Ahern.
> 
> 2) Revert RCU locking change for bonding netpoll, causes worse problems
>    than it solves.
> 
> 3) pskb_trim_rcsum_slow() doesn't handle odd trim offsets, resulting in
>    erroneous bad hw checksum triggers with CHECKSUM_COMPLETE devices.
>    From Dimitris Michailidis.
> 
> Please pull, thanks a lot!

Great, I appended one more bug fix to this pull request, a revert to
some neighbour code changes that adjust notifications in a way that
confuses some apps.

====================
>From d2fb4fb8ee91c1b8a1dbba6afda6f5ed2eb28bdc Mon Sep 17 00:00:00 2001
From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Sat, 20 Oct 2018 18:09:31 -0700
Subject: [PATCH] Revert "neighbour: force neigh_invalidate when NUD_FAILED
 update is from admin"

This reverts commit 8e326289e3069dfc9fa9c209924668dd031ab8ef.

This patch results in unnecessary netlink notification when one
tries to delete a neigh entry already in NUD_FAILED state. Found
this with a buggy app that tries to delete a NUD_FAILED entry
repeatedly. While the notification issue can be fixed with more
checks, adding more complexity here seems unnecessary. Also,
recent tests with other changes in the neighbour code have
shown that the INCOMPLETE and PROBE checks are good enough for
the original issue.

Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 net/core/neighbour.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 91592fceeaad..4e07824eec5e 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1148,8 +1148,7 @@ int neigh_update(struct neighbour *neigh, const u8 *lladdr, u8 new,
 		neigh->nud_state = new;
 		err = 0;
 		notify = old & NUD_VALID;
-		if (((old & (NUD_INCOMPLETE | NUD_PROBE)) ||
-		     (flags & NEIGH_UPDATE_F_ADMIN)) &&
+		if ((old & (NUD_INCOMPLETE | NUD_PROBE)) &&
 		    (new & NUD_FAILED)) {
 			neigh_invalidate(neigh);
 			notify = 1;
-- 
2.17.2