netdev - Re: [PATCH v2 05/17] octeontx2-af: Config NPC KPU engines with parser profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a38=WKCikQyCHCBOAwXn0GzyEPpCEOjK=VbqLBtGAi=fQ@mail.gmail.com>
Date:   Fri, 26 Oct 2018 14:07:19 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-soc@...r.kernel.org, Sunil Goutham <sgoutham@...vell.com>
Subject: Re: [PATCH v2 05/17] octeontx2-af: Config NPC KPU engines with parser profile

On 10/22/18, sunil.kovvuri@...il.com <sunil.kovvuri@...il.com> wrote:
> From: Sunil Goutham <sgoutham@...vell.com>
>

> +struct npc_kpu_action0 {
> +#if defined(__BIG_ENDIAN_BITFIELD)
> +	u64 rsvd_63_57     : 7;
> +	u64 byp_count      : 3;
> +	u64 capture_ena    : 1;
> +	u64 parse_done     : 1;
> +	u64 next_state     : 8;
> +	u64 rsvd_43        : 1;
> +	u64 capture_lid    : 3;

This looks like it again introduces a problem on bit-endian kernels,
since you have fields that span multiple bytes. Could you rewrite
it to avoid the use of bitfields?

    Arnd