netdev - Re: [Patch net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <733ceb85-a9c4-6c3f-fc13-39cf15cabd80@cogentembedded.com>
Date:   Sat, 27 Oct 2018 22:02:13 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Huazhong Tan <tanhuazhong@...wei.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        lipeng321@...wei.com
Subject: Re: [Patch net 05/11] net: hns3: remove unnecessary queue reset in
 the hns3_uninit_all_ring()

Hello!

On 27.10.2018 5:41, Huazhong Tan wrote:

> It is not necessary to reset the queue in the hns3_uninit_all_ring(),
> since the queue is stopped in the down operation, and will be resetted

    s/resetted/reset/.

> in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING
> flag in the hclge_reset_tqp() is not correct, because we need to reset
> tqp during pf reset, otherwise it may cause queue not be resetted to

    Same here.

> working state problem.
>
> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
[...]

MBR, Sergei