netdev - Re: [Patch net 09/11] net: hns3: bugfix for handling mailbox while the command queue reinitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <771035e9-2e0c-9438-659b-5a54438c620f@cogentembedded.com>
Date:   Sat, 27 Oct 2018 22:05:31 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Huazhong Tan <tanhuazhong@...wei.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        lipeng321@...wei.com
Subject: Re: [Patch net 09/11] net: hns3: bugfix for handling mailbox while
 the command queue reinitialized

On 27.10.2018 5:41, Huazhong Tan wrote:

> In a multi-core machine, the mailbox service and reset service
> will be executed at the same time. The reset server will re-initialize
> the commond queue, before that, the mailbox handler can only get some

    Command?

> invalid messages.
>
> The HCLGE_STATE_CMD_DISABLE flag means that the command queue is not
> available and needs to be reinitialized. Therefore, when the mailbox
> hanlder recognizes this flag, it should not process the command.

    Handler.

>
> Fixes: dde1a86e93ca ("net: hns3: Add mailbox support to PF driver")
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
> index 04462a3..6ac2fab 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
> @@ -400,6 +400,12 @@ void hclge_mbx_handler(struct hclge_dev *hdev)
>
>  	/* handle all the mailbox requests in the queue */
>  	while (!hclge_cmd_crq_empty(&hdev->hw)) {
> +		if (test_bit(HCLGE_STATE_CMD_DISABLE, &hdev->state)) {
> +			dev_warn(&hdev->pdev->dev,
> +				 "command queue need re-initialize\n");

    Needs re-initializing.

[...]

MBR, Sergei