netdev - Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd3e9a2a-e6ef-ceb0-6863-85eaf36841ee@cogentembedded.com>
Date:   Sun, 28 Oct 2018 11:09:03 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Huazhong Tan <tanhuazhong@...wei.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linuxarm@...wei.com,
        salil.mehta@...wei.com, yisen.zhuang@...wei.com,
        lipeng321@...wei.com, linyunsheng@...wei.com
Subject: Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in
 the hns3_uninit_all_ring()

Hello!

On 28.10.2018 6:34, Huazhong Tan wrote:

> It is not necessary to reset the queue in the hns3_uninit_all_ring(),
> since the queue is stopped in the down operation, and will be reset
> in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING

    Operation.

> flag in the hclge_reset_tqp() is not correct, because we need to reset
> tqp during pf reset, otherwise it may cause queue not be reset to

    Not being reset?

> working state problem.
> 
> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC")
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
[...]

MBR, Sergei