netdev - Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <939d1c9c-a2eb-d6a1-f3c2-caa1a858d947@huawei.com>
Date:   Mon, 29 Oct 2018 08:54:57 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linuxarm@...wei.com>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <lipeng321@...wei.com>, <linyunsheng@...wei.com>
Subject: Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in
 the hns3_uninit_all_ring()



On 2018/10/28 16:09, Sergei Shtylyov wrote:
> Hello!
> 
> On 28.10.2018 6:34, Huazhong Tan wrote:
> 
>> It is not necessary to reset the queue in the hns3_uninit_all_ring(),
>> since the queue is stopped in the down operation, and will be reset
>> in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING
> 
>     Operation.
> 

yes, sorry for my poor spelling

>> flag in the hclge_reset_tqp() is not correct, because we need to reset
>> tqp during pf reset, otherwise it may cause queue not be reset to
> 
>     Not being reset?
> 

yes, thanks.

>> working state problem.
>>
>> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver 
>> for hip08 SoC")
>> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> [...]
> 
> MBR, Sergei
> 

Greeting.
Huazhong

>