netdev - Re: [PATCH] Fix ss Netid column and Local/Peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1657380.VKiAY23QHg@yo-gs>
Date:   Mon, 29 Oct 2018 21:07:47 +0100
From:   "Yoann P." <yoann.p.public@...il.com>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH] Fix ss Netid column and Local/Peer_Address




> On Mon, 29 Oct 2018 19:20:36 +0100
> 
> Stefano Brivio <sbrivio@...hat.com> wrote:
> > The actual issue seems to be that in some cases the left delimiter for
> > the State column is not printed
> 
> Much worse, we always print the left delimiter of the last buffered
> column, which is usually empty. My bad.
> 
> The issue is not so visible in general as we almost always have spaces
> to distribute around, but not if you start going below 70/75 columns.
> Can you try this?
> 
> diff --git a/misc/ss.c b/misc/ss.c
> index f99b6874c228..90986b1dc15f 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -1260,7 +1260,7 @@ static void render(void)
>         while (token) {
>                 /* Print left delimiter only if we already started a line */
> if (line_started++)
> -                       printed = printf("%s", current_field->ldelim);
> +                       printed = printf("%s", f->ldelim);
>                 else
>                         printed = 0;


I can't reproduce the issue with this modification. :).